Welcome to Soft32 Linux Forums!
FAQFAQ    SearchSearch      ProfileProfile    Private MessagesPrivate Messages   Log inLog in

[PATCH] trivial: fix checking socket() in net tstamp example

 
   Soft32 Home -> Linux -> Kernel RSS
Next:  [gentoo-user] cdrecord fails to burn dvd  
Author Message
Ali Gholami Rudi

External


Since: Nov 08, 2009
Posts: 2



(Msg. 1) Posted: Sun Nov 08, 2009 11:20 am
Post subject: [PATCH] trivial: fix checking socket() in net tstamp example
Archived from groups: linux>kernel (more info?)

Signed-off-by: Ali Gholami Rudi <ali DeleteThis @rudi.ir>
---
.../networking/timestamping/timestamping.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/networking/timestamping/timestamping.c b/Documentation/networking/timestamping/timestamping.c
index a7936fe..bab619a 100644
--- a/Documentation/networking/timestamping/timestamping.c
+++ b/Documentation/networking/timestamping/timestamping.c
@@ -370,7 +370,7 @@ int main(int argc, char **argv)
}

sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
- if (socket < 0)
+ if (sock < 0)
bail("socket");

memset(&device, 0, sizeof(device));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo DeleteThis @vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
Login to vote
Patrick Ohly

External


Since: Nov 19, 2008
Posts: 17



(Msg. 2) Posted: Sun Nov 08, 2009 1:20 pm
Post subject: Re: [PATCH] trivial: fix checking socket() in net tstamp example [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

On Sun, 2009-11-08 at 15:59 +0000, Ali Gholami Rudi wrote:
> Signed-off-by: Ali Gholami Rudi <ali.DeleteThis@rudi.ir>
> ---
> .../networking/timestamping/timestamping.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/networking/timestamping/timestamping.c b/Documentation/networking/timestamping/timestamping.c
> index a7936fe..bab619a 100644
> --- a/Documentation/networking/timestamping/timestamping.c
> +++ b/Documentation/networking/timestamping/timestamping.c
> @@ -370,7 +370,7 @@ int main(int argc, char **argv)
> }
>
> sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
> - if (socket < 0)
> + if (sock < 0)

Argh, of course you are right. FWIW, acknowledged.

--
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.DeleteThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
Login to vote
Emilio G. Cota

External


Since: Nov 08, 2009
Posts: 1



(Msg. 3) Posted: Sun Nov 08, 2009 3:20 pm
Post subject: What's the state of the TX timestamping? [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

[dropped trivial.DeleteThis@kernel.org since this is not relevant to them]

by the way Patrick,

A few months ago I tried to implement TX timestamping for a card
I was working on [1]. I wasn't quite successful (sorry can't be more
explicit, I haven't touched it since then) and thought the reason
was that the implementation was half-baked because David reverted
it--I got to that conclusion after reading this thread in
linux-net ("TX time stamping"):

http://thread.gmane.org/gmane.linux.network/121378/

Could you please tell me what the state of TX timestamping is?
Did David revert it or not? I can't find a revert commit.

Thanks,
Emilio

[1] http://www.ohwr.org/twiki/bin/view/OHR/WhiteRabbit/WhiteRabbit

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.DeleteThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
Login to vote
Ali Gholami Rudi

External


Since: Nov 08, 2009
Posts: 2



(Msg. 4) Posted: Sun Nov 08, 2009 5:20 pm
Post subject: Re: [PATCH] trivial: fix checking socket() in net tstamp example [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Hi Patrick,

Patrick Ohly <patrick.ohly.DeleteThis@intel.com> wrote:
> > --- a/Documentation/networking/timestamping/timestamping.c
> > +++ b/Documentation/networking/timestamping/timestamping.c
> > @@ -370,7 +370,7 @@ int main(int argc, char **argv)
> > }
> >
> > sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP);
> > - if (socket < 0)
> > + if (sock < 0)
>
> Argh, of course you are right. FWIW, acknowledged.

By the way, I tried igb hardware timestamp but HWTSTAMP_FILTER_ALL works
almost like HWTSTAMP_FILTER_PTP_*. Isn't it supposed to timestamp all
of the incoming packets? Maybe there is something wrong with my test
setup?

Thanks,
Ali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.DeleteThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
Login to vote
Display posts from previous:   
Related Topics:
[PATCH 0/5] [RFC] AF_RXRPC socket family implementation - These patches together supply secure client-side RxRPC connectivity as a Linux kernel socket family. Only the..

[PATCH 0/5] [RFC] AF_RXRPC socket family implementation [t.. - These patches together supply secure client-side RxRPC connectivity as a Linux kernel socket family. Only the..

[PATCH 0/5] [RFC] AF_RXRPC socket family implementation [t.. - These patches together supply secure client-side RxRPC connectivity as a Linux kernel socket family. Only the..

[PATCH 0/9] AF_RXRPC socket family and AFS rewrite - The first of these patches together provide secure client-side RxRPC connectivity as a Linux kernel socket family. Onl...

[PATCH 0/8] AF_RXRPC socket family and AFS rewrite [try #2] - The first of these patches together provide secure client-side RxRPC connectivity as a Linux kernel socket family. Onl...

[PATCH] Add "is_power_of_2" checking to log2.h. - Add the inline function "is_power_of_2()" to log2.h, where the value zero is *not* considered to be a power o...
       Soft32 Home -> Linux -> Kernel All times are: Pacific Time (US & Canada) (change)
Page 1 of 1

 
You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

Categories:
 Windows
  Linux
 Mac
 PDA


[ Contact us | Terms of Service/Privacy Policy ]