Welcome to Soft32 Linux Forums!
FAQFAQ    SearchSearch      ProfileProfile    Private MessagesPrivate Messages   Log inLog in

[PATCH] staging/otus: fix checkpatch warnings on wrap_buf

 
   Soft32 Home -> Linux -> Kernel RSS
Next:  [patch] aio: Don't zero out the pages array insid..  
Author Message
Thiago Farina

External


Since: Oct 30, 2009
Posts: 2



(Msg. 1) Posted: Fri Oct 30, 2009 9:20 am
Post subject: [PATCH] staging/otus: fix checkpatch warnings on wrap_buf
Archived from groups: linux>kernel (more info?)

Fix a bunch of warnings like "foo* bar" which should be "foo *bar".

Signed-off-by: Thiago Farina <tfransosi.DeleteThis@gmail.com>
---
drivers/staging/otus/wrap_buf.c | 33 ++++++++++++---------------------
1 files changed, 12 insertions(+), 21 deletions(-)

diff --git a/drivers/staging/otus/wrap_buf.c b/drivers/staging/otus/wrap_buf.c
index a0f677a..6b11193 100644
--- a/drivers/staging/otus/wrap_buf.c
+++ b/drivers/staging/otus/wrap_buf.c
@@ -27,57 +27,49 @@
#include "oal_dt.h"
#include "usbdrv.h"

-
#include <linux/netlink.h>

#include <net/iw_handler.h>

-
/* Called to allocate buffer, must return a continue buffer space */
-zbuf_t* zfwBufAllocate(zdev_t* dev, u16_t len)
+zbuf_t *zfwBufAllocate(zdev_t *dev, u16_t len)
{
- zbuf_t* buf;
+ zbuf_t *buf;

- /* Allocate SKB for packet*/
+ /* Allocate SKB for packet */
buf = dev_alloc_skb(len);

return buf;
}

-
/* Called to free buffer, replace below 3 functions */
-void zfwBufFree(zdev_t* dev, zbuf_t* buf, u16_t status)
+void zfwBufFree(zdev_t *dev, zbuf_t *buf, u16_t status)
{
dev_kfree_skb_any(buf);
}

/* Called to adjust buffer size and head pointer */
-u16_t zfwBufRemoveHead(zdev_t* dev, zbuf_t* buf, u16_t size)
+u16_t zfwBufRemoveHead(zdev_t *dev, zbuf_t *buf, u16_t size)
{
- //zm_assert(buf->len > size);
+ /* zm_assert(buf->len > size); */

buf->data += size;
buf->len -= size;
return 0;
}

-
-
-
/* return tail if head==NULL, called to chain multiple buffer together */
/* Used to chain Rx buffer to form a frame. if the prepared Rx buffer */
-/* is greater than an ethernet frame(1518+32 byte), then this function */
+/* is greater than an ethernet frame(1518+32 byte), then this function */
/* will only be called with head=NULL. */
-u16_t zfwBufChain(zdev_t* dev, zbuf_t** head, zbuf_t* tail)
+u16_t zfwBufChain(zdev_t *dev, zbuf_t **head, zbuf_t *tail)
{
-
*head = tail;
return 0;
}

-
/* Called when doing infra-bss forwarding */
-u16_t zfwBufCopy(zdev_t* dev, zbuf_t* dst, zbuf_t* src)
+u16_t zfwBufCopy(zdev_t *dev, zbuf_t *dst, zbuf_t *src)
{
memcpy(dst->data, src->data, src->len);
dst->tail = dst->data;
@@ -85,9 +77,8 @@ u16_t zfwBufCopy(zdev_t* dev, zbuf_t* dst, zbuf_t* src)
return 0;
}

-
/* Called to adjust buffer size and tail pointer */
-u16_t zfwBufSetSize(zdev_t* dev, zbuf_t* buf, u16_t size)
+u16_t zfwBufSetSize(zdev_t *dev, zbuf_t *buf, u16_t size)
{
#ifdef NET_SKBUFF_DATA_USES_OFFSET
buf->tail = 0;
@@ -101,11 +92,11 @@ u16_t zfwBufSetSize(zdev_t* dev, zbuf_t* buf, u16_t size)
return 0;
}

-u16_t zfwBufGetSize(zdev_t* dev, zbuf_t* buf)
+u16_t zfwBufGetSize(zdev_t *dev, zbuf_t *buf)
{
return buf->len;
}

-void zfwCopyBufContext(zdev_t* dev, zbuf_t* source, zbuf_t* dst)
+void zfwCopyBufContext(zdev_t *dev, zbuf_t *source, zbuf_t *dst)
{
}
--
1.6.5.1.61.ge79999

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.DeleteThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
Login to vote
Thiago Farina

External


Since: Oct 30, 2009
Posts: 2



(Msg. 2) Posted: Fri Nov 06, 2009 7:20 pm
Post subject: Re: [PATCH] staging/otus: fix checkpatch warnings on wrap_buf [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Hi Greg, this one too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.RemoveThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
Login to vote
Display posts from previous:   
Related Topics:
[PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs.. - From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen <hnguyen at de.ibm.com...

[PATCH] update checkpatch.pl to version 0.03 - This version brings a host of changes to cure false positives and bugs detected on patches submitted to lkml and -mm. ....

[PATCH] update checkpatch.pl to version 0.04 - This version brings a some new tests, and a host of changes to fix false positives, of particular note: - check for....

[PATCH] update checkpatch.pl to version 0.05 - This version brings a some new tests, and a host of changes to fix false positives, of particular note: - detect 'var...

[PATCH] update checkpatch.pl to version 0.06 - Update to checkpatch.pl v0.06. Of note: - do { and else handled correctly as control structures for { matching -..

[PATCH] Check charset in scripts/checkpatch.pl - Reject all legacy 8-bit character sets and allow only ASCII or UTF-8 to be added to files or used in patch descriptions...
       Soft32 Home -> Linux -> Kernel All times are: Pacific Time (US & Canada) (change)
Page 1 of 1

 
You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

Categories:
 Windows
  Linux
 Mac
 PDA


[ Contact us | Terms of Service/Privacy Policy ]