Welcome to Soft32 Linux Forums!
FAQFAQ    SearchSearch      ProfileProfile    Private MessagesPrivate Messages   Log inLog in

[PATCH 0/2] Fixes for Fedora

 
   Soft32 Home -> Linux -> PacKaGe RSS
Next:  RFS: gnurobbo (updated package)  
Author Message
Felipe Contreras

External


Since: Sep 13, 2009
Posts: 13



(Msg. 1) Posted: Sun Oct 25, 2009 9:20 am
Post subject: [PATCH 0/2] Fixes for Fedora
Archived from groups: linux>debian>maint>dpkg (more info?)

Currently dpkg doesn't build on Fedora, and these patches fix that.

I sent these a long time ago to Guillem but it looks like they fell through the
cracks.

Felipe Contreras (2):
Fix build when selinux pkg-config is not available
Fix build when po4a is not available

Makefile.am | 6 +++++-
configure.ac | 3 +++
m4/libs.m4 | 14 +++++++++++---
3 files changed, 19 insertions(+), 4 deletions(-)


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST RemoveThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster RemoveThis @lists.debian.org
Back to top
Login to vote
Felipe Contreras

External


Since: Sep 13, 2009
Posts: 13



(Msg. 2) Posted: Sun Oct 25, 2009 9:20 am
Post subject: [PATCH 1/2] Fix build when selinux pkg-config is not available [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Signed-off-by: Felipe Contreras <felipe.contreras.DeleteThis@gmail.com>
---
m4/libs.m4 | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/m4/libs.m4 b/m4/libs.m4
index 255a7ef..a99afbe 100644
--- a/m4/libs.m4
+++ b/m4/libs.m4
@@ -70,10 +70,18 @@ if test "x$with_selinux" != "xno"; then
AC_CHECK_LIB([selinux], [is_selinux_enabled],
[AC_DEFINE(WITH_SELINUX, 1,
[Define to 1 to compile in SELinux support])
- if test "x$with_selinux" = "xstatic"; then
- dpkg_selinux_libs="-Wl,-Bstatic "$(pkg-config --static --libs libselinux)" -Wl,-Bdynamic"
+ if test $(pkg-config --exists libselinux); then
+ if test "x$with_selinux" = "xstatic"; then
+ dpkg_selinux_libs="-Wl,-Bstatic "$(pkg-config --static --libs libselinux)" -Wl,-Bdynamic"
+ else
+ dpkg_selinux_libs=$(pkg-config --libs libselinux)
+ fi
else
- dpkg_selinux_libs=$(pkg-config --libs libselinux)
+ if test "x$with_selinux" = "xstatic"; then
+ dpkg_selinux_libs="-Wl,-Bstatic -lselinux -Wl,-Bdynamic"
+ else
+ dpkg_selinux_libs="-lselinux"
+ fi
fi
SELINUX_LIBS="${SELINUX_LIBS:+$SELINUX_LIBS }$dpkg_selinux_libs"
with_selinux="yes"],
--
1.6.5.1


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST.DeleteThis@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.DeleteThis@lists.debian.org
Back to top
Login to vote
Tollef Fog Heen

External


Since: Jan 02, 2007
Posts: 13



(Msg. 3) Posted: Sun Oct 25, 2009 5:20 pm
Post subject: Re: [PATCH 1/2] Fix build when selinux pkg-config is not available [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

]] Felipe Contreras

| - if test "x$with_selinux" = "xstatic"; then
| - dpkg_selinux_libs="-Wl,-Bstatic "$(pkg-config --static --libs libselinux)" -Wl,-Bdynamic"
| + if test $(pkg-config --exists libselinux); then

This makes it impossible to override the location of pkg-config by
setting PKG_CONFIG. Please use the PKG_CHECK_MODULES macro (or at least
the PKG_PROG_PKG_CONFIG macro and then call $PKG_CONFIG yourself).

(Yes, I know that the old code has the same problem.)

--
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST DeleteThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster DeleteThis @lists.debian.org
Back to top
Login to vote
Jonathan Nieder

External


Since: Feb 04, 2009
Posts: 34



(Msg. 4) Posted: Sun Oct 25, 2009 5:20 pm
Post subject: Re: [PATCH 0/2] Fixes for Fedora [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Felipe Contreras wrote:

> Currently dpkg doesn't build on Fedora, and these patches fix that.
>
> I sent these a long time ago to Guillem but it looks like they fell through the
> cracks.
>
> Felipe Contreras (2):
> Fix build when selinux pkg-config is not available
> Fix build when po4a is not available
>
> Makefile.am | 6 +++++-
> configure.ac | 3 +++
> m4/libs.m4 | 14 +++++++++++---
> 3 files changed, 19 insertions(+), 4 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder.DeleteThis@gmail.com>


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST.DeleteThis@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.DeleteThis@lists.debian.org
Back to top
Login to vote
Guillem Jover

External


Since: Nov 25, 2006
Posts: 160



(Msg. 5) Posted: Thu Oct 29, 2009 1:20 pm
Post subject: Re: [PATCH 2/2] Fix build when po4a is not available [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Hi!

On Sun, 2009-10-25 at 15:40:16 +0200, Felipe Contreras wrote:
> diff --git a/Makefile.am b/Makefile.am
> index 8fe8726..aaa7d85 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -4,6 +4,10 @@ if WITH_DSELECT
> MAYBE_DSELECT = dselect
> endif
>
> +if WITH_PO4A
> + MAYBE_MAN = man
> +endif
> +
> SUBDIRS = \
> lib \
> dpkg-deb \
> @@ -13,7 +17,7 @@ SUBDIRS = \
> $(MAYBE_DSELECT) \
> scripts \
> po \
> - man
> + $(MAYBE_MAN)
>
> ACLOCAL_AMFLAGS = -I m4
>
> diff --git a/configure.ac b/configure.ac
> index 52f019c..67bba57 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -59,6 +59,9 @@ AC_PROG_LEX
> AC_PROG_RANLIB
> DPKG_PROG_PERL
>
> +AC_CHECK_PROG([PO4A], [po4a])
> +AM_CONDITIONAL([WITH_PO4A], [test -n "$PO4A"])
> +
> # Checks for operating system services and capabilities.
> AC_SYS_LARGEFILE

The problem with this patch is that it disables man pages completely
when there's no po4a, it also does not honour the NLS setting. I've
pushed this instead:

<http://git.debian.org/?p=dpkg/dpkg.git;a=commit;h=679d1d75>

Thanks!

regards,
guillem


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST.TakeThisOut@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.TakeThisOut@lists.debian.org
Back to top
Login to vote
Guillem Jover

External


Since: Nov 25, 2006
Posts: 160



(Msg. 6) Posted: Fri Oct 30, 2009 9:20 am
Post subject: Re: [PATCH 0/2] Fixes for Fedora [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Hi!

On Sun, 2009-10-25 at 15:40:14 +0200, Felipe Contreras wrote:
> Currently dpkg doesn't build on Fedora, and these patches fix that.
>
> I sent these a long time ago to Guillem but it looks like they fell
> through the cracks.

Yeah, had them around but had forgotten about them, sorry.

> Felipe Contreras (2):
> Fix build when selinux pkg-config is not available

Didn't get this one, so I fished it from the web archive. I've added
the needed -lsepol to the static non-pkg-config case.

Pushed, thanks!

regards,
guillem


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST.DeleteThis@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.DeleteThis@lists.debian.org
Back to top
Login to vote
Guillem Jover

External


Since: Nov 25, 2006
Posts: 160



(Msg. 7) Posted: Fri Oct 30, 2009 11:20 am
Post subject: Re: [PATCH 1/2] Fix build when selinux pkg-config is not available [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Hi!

On Sun, 2009-10-25 at 22:40:26 +0100, Tollef Fog Heen wrote:
> ]] Felipe Contreras
>
> | - if test "x$with_selinux" = "xstatic"; then
> | - dpkg_selinux_libs="-Wl,-Bstatic "$(pkg-config --static --libs libselinux)" -Wl,-Bdynamic"
> | + if test $(pkg-config --exists libselinux); then
>
> This makes it impossible to override the location of pkg-config by
> setting PKG_CONFIG. Please use the PKG_CHECK_MODULES macro (or at least
> the PKG_PROG_PKG_CONFIG macro and then call $PKG_CONFIG yourself).
>
> (Yes, I know that the old code has the same problem.)

Ah, right, my fault, fixed it now, thanks!

regards,
guillem


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST RemoveThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster RemoveThis @lists.debian.org
Back to top
Login to vote
Felipe Contreras

External


Since: Sep 13, 2009
Posts: 13



(Msg. 8) Posted: Sun Nov 15, 2009 5:20 pm
Post subject: Re: [PATCH 0/2] Fixes for Fedora [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

On Fri, Oct 30, 2009 at 4:19 PM, Guillem Jover <guillem DeleteThis @debian.org> wrote:
> Didn't get this one, so I fished it from the web archive. I've added
> the needed -lsepol to the static non-pkg-config case.
>
> Pushed, thanks!

Thanks, it builds fine now Smile

--
Felipe Contreras


--
To UNSUBSCRIBE, email to debian-dpkg-REQUEST DeleteThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster DeleteThis @lists.debian.org
Back to top
Login to vote
Display posts from previous:   
Related Topics:
[PATCH 6/11] Vmi timer no idle hz fixes.patch - Fix the VMI-Timer no-idle-hz code. Do not setup a one shot alarm if we are keeping the periodic alarm armed. ..

[PATCH 1/9] Vmi timer fixes round two.patch - Critical bugfixes for the VMI-Timer code. 1) Do not setup a one shot alarm if we are keeping the periodic alarm armed....

[PATCH 9/9] Vmi smp fixes.patch - Critical fixes for SMP. Fix a couple functions which needed to be __devinit and fix a bogus parameter to AP startup..

[PATCH 0/3] KVM: Some more fixes - This patchset prevents people from shooting themselves in the foot by loading the wrong module, allows macbook owners....

[PATCH] Various typo fixes. - Correct mis-spellings of "algorithm", "appear", "consistent" and (shame, shame) "ker...

[PATCH] pata_cmd64x - various fixes - This driver still needs more work but for the moment - It's a CMD not ATI driver - Clean up code by using cable method...
       Soft32 Home -> Linux -> PacKaGe All times are: Pacific Time (US & Canada) (change)
Page 1 of 1

 
You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

Categories:
 Windows
  Linux
 Mac
 PDA


[ Contact us | Terms of Service/Privacy Policy ]